From 386b4f57d9447b40268da9738e22d7e665deea02 Mon Sep 17 00:00:00 2001 From: Michael Gordeev Date: Thu, 11 Jun 2020 14:13:22 +0300 Subject: [PATCH] Minor 1.3 (#9) * Empty tabs are now ignored (#8) * Empty collections can't be saved now --- js/background.js | 12 +++++++++--- manifest.json | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/js/background.js b/js/background.js index b78c66b..c92dd17 100644 --- a/js/background.js +++ b/js/background.js @@ -169,9 +169,15 @@ chrome.tabs.onReplaced.addListener(UpdateTheme); function SaveCollection() { - chrome.tabs.query({ currentWindow: true }, function (tabs) + chrome.tabs.query({ currentWindow: true }, function (rawTabs) { - tabs = tabs.filter(i => !i.url.startsWith("chrome-extension") && !i.url.endsWith("TabsAside.html") && !i.pinned); + var tabs = rawTabs.filter(i => !(i.url.startsWith("chrome-extension") && i.url.endsWith("TabsAside.html")) && !i.pinned && !i.url.includes("//newtab")); + + if (tabs.length < 1) + { + alert("No tabs available to save"); + return; + } var collection = { @@ -196,8 +202,8 @@ function SaveCollection() collections = JSON.parse(localStorage.getItem("sets")); + chrome.tabs.remove(rawTabs.filter(i => !i.url.startsWith("chrome-extension") && !i.url.endsWith("TabsAside.html") && !i.pinned).map(tab => tab.id)); chrome.tabs.create({}); - chrome.tabs.remove(tabs.map(tab => tab.id)); }); UpdateTheme(); diff --git a/manifest.json b/manifest.json index e51b5f5..9ac0ef8 100644 --- a/manifest.json +++ b/manifest.json @@ -1,6 +1,6 @@ { "name": "Tabs Aside", - "version": "1.2.2", + "version": "1.3", "manifest_version": 2, "description": "Classic Microsoft Edge \"Tabs Aside\" feature for Chromium browsers", "author": "Michael \"XFox\" Gordeev",