mirror of
https://github.com/XFox111/PasswordGeneratorExtension.git
synced 2026-04-22 08:08:01 +03:00
Patch 2.0.2 (#53)
* Fix for issue #51 - Extension is not working on firefox (#52) * Fix for issue #51 - Extension is not working on firefox * Fix for issue #51 - Replaced @types/chrome with webextension-polyfill * re-Added @types/chrome to allow development tests * Moved local import after module imports * Bump @types/node from 18.7.18 to 18.11.0 (#48) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.7.18 to 18.11.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @fluentui/react-icons from 2.0.183 to 2.0.185 (#50) Bumps [@fluentui/react-icons](https://github.com/microsoft/fluentui-system-icons) from 2.0.183 to 2.0.185. - [Release notes](https://github.com/microsoft/fluentui-system-icons/releases) - [Commits](https://github.com/microsoft/fluentui-system-icons/commits) --- updated-dependencies: - dependency-name: "@fluentui/react-icons" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Fox <eugene.xfox@outlook.com> * Bump typescript from 4.8.3 to 4.8.4 (#47) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.3 to 4.8.4. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v4.8.3...v4.8.4) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Fox <eugene.xfox@outlook.com> * Bump @types/jest from 29.1.1 to 29.1.2 (#44) Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.1.1 to 29.1.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Fox <eugene.xfox@outlook.com> * Bump @fluentui/react-components from 9.3.2 to 9.5.1 (#49) Bumps [@fluentui/react-components](https://github.com/microsoft/fluentui) from 9.3.2 to 9.5.1. - [Release notes](https://github.com/microsoft/fluentui/releases) - [Changelog](https://github.com/microsoft/fluentui/blob/master/azure-pipelines.release-fluentui.yml) - [Commits](https://github.com/microsoft/fluentui/compare/@fluentui/react-components_v9.3.2...@fluentui/react-components_v9.5.1) --- updated-dependencies: - dependency-name: "@fluentui/react-components" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugene Fox <eugene.xfox@outlook.com> * - Updated craco.config.ts to improve extension's stability - Renamed manifest.firefox.json to manifest.v2.json - Added fallbacks for invalid password length - Migrated FluentUI Dialog to stable release - Updated WebExt compat API * Updated project formatting * Feedback button now navigates to webstore page * Update code style guidelines * Updated extension version to 2.0.2 * Fixed pipelines * Fixed AboutSection.tsx * Fixed CodeQL issues * Fixed feedback link not working * Fixed feedback button again Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Andry Herizo RAJOELISON <finalherizo@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This commit is contained in:
Eugene Fox
GitHub
+94
-16
@@ -112,7 +112,7 @@ This section represents how contributors should interact with codebase implement
|
||||
7. Done
|
||||
|
||||
#### Release
|
||||
Next stage is release. Release performs on every push to main (which makes functional changes to the source code). Release performs manually by @XFox111 into: Chrome webstore, Edge webstore and GitHub releases
|
||||
Next stage is release. Release performs on every push to main (which makes functional changes to the source code). Release performs manually by @XFox111 into: Chrome, Firefox, Edge webstores as well as GitHub releases
|
||||
|
||||
### Coding guidelines
|
||||
#### Indentation
|
||||
@@ -121,7 +121,8 @@ We use tabs, not spaces.
|
||||
#### Names
|
||||
The project naming rules inherit [.NET Naming Guidelines](https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/naming-guidelines). Nevertheless there'is some distinction with the guidelines as well as additions to the one:
|
||||
- Use `camelCase` for variables instead of `CamelCase` stated in [Capitalization Conventions](https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/capitalization-conventions#capitalization-rules-for-identifiers)
|
||||
- Use `snake_case` for file names
|
||||
- Use `camelCase` for files in `public` directory
|
||||
- Use `PascalCase` for files in `src` directory
|
||||
|
||||
#### Comments
|
||||
Leave as more comments as you can. Remember: the more detailed documentation your code has the less programmers will curse you in the future
|
||||
@@ -131,43 +132,48 @@ Use "double quotes" wherever it's possible
|
||||
|
||||
#### Style
|
||||
- Prefer to use lambda functions
|
||||
- Put curly braces on new lines
|
||||
- Always put curly braces on new lines
|
||||
- Wrong:
|
||||
```
|
||||
```js
|
||||
if (condition) {
|
||||
...
|
||||
}
|
||||
```
|
||||
- Correct:
|
||||
```
|
||||
```js
|
||||
if (condition)
|
||||
{
|
||||
...
|
||||
}
|
||||
```
|
||||
- Put spaces between operators and before braces in methods declarations, conditionals and loops
|
||||
> **Note:** For JSON files put opening brace on the same line as the key
|
||||
- Put spaces between operators, conditionals and loops
|
||||
- Wrong:
|
||||
- `y=k*x+b`
|
||||
- `function FunctionName()`
|
||||
```js
|
||||
y=k*x+b;
|
||||
if(condition) { ... }
|
||||
```
|
||||
- Correct:
|
||||
- `y = k * x + b`
|
||||
- `function FunctionName ()`
|
||||
- Use ternary conditionals wherever it's possible
|
||||
```js
|
||||
y = k * x + b;
|
||||
if (condition) { ... }
|
||||
```
|
||||
- Use ternary conditionals wherever it's possible, unless it's too long
|
||||
- Wrong:
|
||||
```
|
||||
```js
|
||||
var s;
|
||||
if (condition)
|
||||
s = "Life";
|
||||
else
|
||||
s = "Death"
|
||||
s = "Death";
|
||||
```
|
||||
- Correct:
|
||||
```
|
||||
```js
|
||||
var s = condition ? "Life" : "Death";
|
||||
```
|
||||
- Do not surround loop and conditional bodies with curly braces if they can be avoided
|
||||
- Wrong:
|
||||
```
|
||||
```js
|
||||
if (condition)
|
||||
{
|
||||
console.log("Hello, World!");
|
||||
@@ -178,12 +184,84 @@ Use "double quotes" wherever it's possible
|
||||
}
|
||||
```
|
||||
- Correct
|
||||
```
|
||||
```js
|
||||
if (condition)
|
||||
console.log("Hello, World!");
|
||||
else
|
||||
return;
|
||||
```
|
||||
- Prefer export modules as default
|
||||
- Wrong:
|
||||
```js
|
||||
export class MyClass { ... }
|
||||
```
|
||||
- Correct:
|
||||
```js
|
||||
export default class MyClass { ... }
|
||||
```
|
||||
- Prefer export modules as classes unless it is excessive
|
||||
- Wrong:
|
||||
```ts
|
||||
export function MyFunction1() { ... }
|
||||
export function MyFunction2() { ... }
|
||||
export default class MyClass2()
|
||||
{
|
||||
public static GetDate(timestamp: number): Date
|
||||
{
|
||||
return new Date(timestamp);
|
||||
}
|
||||
}
|
||||
```
|
||||
- Correct:
|
||||
```js
|
||||
export default class MyClass1
|
||||
{
|
||||
public static MyFunction1() { ... }
|
||||
public static MyFunction2() { ... }
|
||||
}
|
||||
export default GetDate(timestamp: number): Date
|
||||
{
|
||||
return new Date(timestamp);
|
||||
}
|
||||
```
|
||||
- When JSX attributes take too much space, put each attribute on a new line and put additional line before component's content
|
||||
- Wrong:
|
||||
```tsx
|
||||
<HelloWorld attribute1="value" attribute2={ value } attribute3="value">My content here</HelloWorld>
|
||||
<HelloWorld attribute1="value"
|
||||
attribute2={ value }
|
||||
attribute3="value">My content here</HelloWorld>
|
||||
<HelloWorld attribute1="value"
|
||||
attribute2={ value }
|
||||
attribute3="value">
|
||||
My content here
|
||||
</HelloWorld>
|
||||
<HelloWorld
|
||||
attribute1="value"
|
||||
attribute2={ value }
|
||||
attribute3="value">
|
||||
My content here
|
||||
</HelloWorld>
|
||||
```
|
||||
- Correct:
|
||||
```tsx
|
||||
<HelloWorld
|
||||
attribute1="value"
|
||||
attribute2={ value }
|
||||
attribute3="value">
|
||||
|
||||
My content here
|
||||
</HelloWorld>
|
||||
```
|
||||
- If JSX component doesn't have content, put space before closing tag
|
||||
- Wrong:
|
||||
```tsx
|
||||
<HelloWorld attribute1="value" attribute2={ value } attribute3="value"/>
|
||||
```
|
||||
- Correct:
|
||||
```tsx
|
||||
<HelloWorld attribute1="value" attribute2={ value } attribute3="value" />
|
||||
```
|
||||
|
||||
### Finding an issue to work on
|
||||
Check out the [full issues list](https://github.com/XFox111/PasswordGeneratorExtension/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue) for a list of all potential areas for contributions. **Note** that just because an issue exists in the repository does not mean we will accept a contribution. There are several reasons we may not accept a pull request like:
|
||||
|
||||
Reference in New Issue
Block a user